Trust Evaluation#465
Open
StjepanovicSrdjan wants to merge 11 commits into
Open
Conversation
StjepanovicSrdjan
force-pushed
the
feature/trust-evaluation
branch
from
3eb01ce to
2115232
Compare
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
StjepanovicSrdjan
force-pushed
the
feature/trust-evaluation
branch
from
e0b2b52 to
59c9d87
Compare
nodh
requested changes
Jun 29, 2026
| * Use VC-K data classes to (de-)serialize received/emitted data | ||
| * Add support for iOS using ISO/IEC 18013-7 Annex C protocol | ||
| * Add support for issuance via the DC API based on the preliminary spec defined in https://github.com/openid/OpenID4VCI/pull/476 | ||
| * Add `TrustListService` for loading LoTE regularly in the background |
| "https://acceptance.trust.tech.ec.europa.eu/lists/eudiw/wallet-providers.json", | ||
| "https://acceptance.trust.tech.ec.europa.eu/lists/eudiw/wrpac-providers.json", | ||
| "https://acceptance.trust.tech.ec.europa.eu/lists/eudiw/mdl-providers.json", | ||
| "https://trust.tech.ec.europa.eu/lists/eudiw/pub-eaa-providers.json" |
Member
There was a problem hiding this comment.
Suggested change
| "https://trust.tech.ec.europa.eu/lists/eudiw/pub-eaa-providers.json" | |
| "https://acceptance.trust.tech.ec.europa.eu/lists/eudiw/pub-eaa-providers.json" |
| val ASIT_PLUS_PROVIDERS = "${PREFIX}asit_plus_providers" | ||
|
|
||
|
|
||
| fun mapUrlToKey(url: String): String? = when { |
| fun TrustStatusBanner(trustState: TrustState, modifier: Modifier = Modifier) { | ||
| val (backgroundColor, contentColor, icon, text) = when (trustState) { | ||
| TrustState.TRUSTED -> listOf( | ||
| Color(0xFFE8F5E9), Color(0xFF2E7D32), |
Member
There was a problem hiding this comment.
Please extract to resources, particularly the strings
| private val verifyJwsObject: VerifyJwsObjectFun = VerifyJwsObjectJades(), | ||
| ) { | ||
| private var job: Job? = null | ||
| val scope = CoroutineScope(SupervisorJob() + Dispatchers.Default) |
Member
There was a problem hiding this comment.
why not use the existing sessionCoroutineScope (see CredentialValidityService)
| trustLists: List<ListOfTrustedEntities>, | ||
| serviceType: String | ||
| ): TrustState { | ||
| return try { |
Member
There was a problem hiding this comment.
cen be converted to a expression body
|
|
||
| val responseBody = response.bodyAsText() | ||
|
|
||
| val jws = JwsCompact.parse<TrustListPayload>(responseBody).getOrThrow() |
Member
There was a problem hiding this comment.
why not converting directly like in https://ktor.io/docs/client-responses.html#json
| verifyJwsObject(jws.first).getOrThrow() | ||
|
|
||
| Napier.i("Successfully validated Trust List signature from $url") | ||
|
|
|
|
||
| if (validationResult.isSuccess) TrustState.TRUSTED else TrustState.UNTRUSTED | ||
| } catch (_: Exception) { | ||
| TrustState.UNTRUSTED |
Member
There was a problem hiding this comment.
Wouldn't UNKNOWN be better suited here? Also we should at least log the exception so Developers can see that something went wrong
| val scope = CoroutineScope(SupervisorJob() + Dispatchers.Default) | ||
| private val client = httpService.buildHttpClient() | ||
| // A-SIT trust list | ||
| val aistIssuerCert = X509Certificate.decodeFromPem(asitRootPem).getOrThrow() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TrustListServicefor loading LoTE regularly in the background